Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FFI build for aarch64-apple-ios-sim #4974

Closed
SWvheerden opened this issue Nov 29, 2022 · 0 comments · Fixed by #5137
Closed

Enable FFI build for aarch64-apple-ios-sim #4974

SWvheerden opened this issue Nov 29, 2022 · 0 comments · Fixed by #5137
Assignees
@SWvheerden @leet4tari
Labels
A-ci Area - Continuous Integration related

Comments

@SWvheerden
Copy link
Collaborator

SWvheerden commented Nov 29, 2022 •
edited
Loading

We cannot build the FFi for aarch64-apple-ios-sim so we cannot use the simulator on the M1.

We need to wait until OpenSSL supports aarch64-apple-ios-sim
sfackler/rust-openssl#1622

Or we need to try and build OpenSSL without vendor support?
@stringhandler stringhandler added the A-ci Area - Continuous Integration related label Nov 30, 2022
@SWvheerden SWvheerden self-assigned this Jan 20, 2023
@SWvheerden SWvheerden mentioned this issue Jan 24, 2023
Merged
stringhandler pushed a commit that referenced this issue Feb 1, 2023
@SWvheerden
fix: feature flag separation for validation (#5137)
0e83463 
Description
---
Removes OpenSSL from the WalletFFI lib as its not required or used by it. 
Fixes validation feature flags. 

Motivation and Context
---
Recent refactor added `base_node` feature flag to the walletFFI. This should not be done as it adds in all the base node 
specific crates that not required by the wallet like randomX, lmdb etc. 
This splits the validation traits and implementations between the features `transactions` and `base_node`.

How Has This Been Tested?
---
Manual and unit tests

Fixes: #4974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

@leet4tari leet4tari

Labels
A-ci Area - Continuous Integration related
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: feature flag separation for validation SWvheerden/tari
3 participants
@SWvheerden @stringhandler @leet4tari