Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tari_crypto hashing API: mmr & wallet #4395

Closed
hansieodendaal opened this issue Aug 5, 2022 · 1 comment
Closed

Implement tari_crypto hashing API: mmr & wallet #4395

hansieodendaal opened this issue Aug 5, 2022 · 1 comment
Assignees
@hansieodendaal
Labels
A-security Area - Security related

Comments

@hansieodendaal
Copy link
Contributor

Effective GitHub hash: d25d726
# Reference Function/Area Yes/No URL URL long
18 base_layer/mmr/src/common.rs:174 pub fn hash_together<D: Digest>( Yes common.rs:174 https://github.com/tari-project/tari/blob/development/base_layer/mmr/src/common.rs#L174
19 base_layer/mmr/src/merkle_mountain_range.rs:137 pub(crate) fn hash_to_root( Yes merkle_mountain_range.rs:137 https://github.com/tari-project/tari/blob/development/base_layer/mmr/src/merkle_mountain_range.rs#L137
20 base_layer/mmr/src/merkle_proof.rs:188 fn check_root<D: Digest>( Yes merkle_proof.rs:188 https://github.com/tari-project/tari/blob/development/base_layer/mmr/src/merkle_proof.rs#L188
21 base_layer/mmr/src/mutable_mmr.rs:122 pub fn get_merkle_root( Yes mutable_mmr.rs:122 https://github.com/tari-project/tari/blob/development/base_layer/mmr/src/mutable_mmr.rs#L122
22 base_layer/wallet/src/output_manager_service/service.rs:2725 fn hash_secret_key( Yes service.rs:2725 https://github.com/tari-project/tari/blob/development/base_layer/wallet/src/output_manager_service/service.rs#L2725
23 base_layer/wallet/src/transaction_service/service.rs:2629 fn hash_secret_key( Yes service.rs:2629 https://github.com/tari-project/tari/blob/development/base_layer/wallet/src/transaction_service/service.rs#L2629
@CjS77
Copy link
Collaborator

CjS77 commented Aug 5, 2022

Nice commit messages ❤️

@hansieodendaal hansieodendaal self-assigned this Aug 8, 2022
@hansieodendaal hansieodendaal mentioned this issue Aug 9, 2022
Merged
stringhandler pushed a commit that referenced this issue Aug 10, 2022
@hansieodendaal
feat: add hashing api to wallet secret keys (#4424)
d944574 
Description
---
Partial fulfillment for #4395:
- base_layer/wallet/src/output_manager_service/service.rs, fn hash_secret_key(...)
- base_layer/wallet/src/transaction_service/service.rs, fn hash_secret_key(...)

Motivation and Context
---
Domain separated hashing as per the `tari_crypto` hashing API is needed for secret keys 

How Has This Been Tested?
---
Unit tests pass
Cucumber tests pass
@hansieodendaal hansieodendaal mentioned this issue Aug 11, 2022
Merged
@hansieodendaal hansieodendaal added the A-security Area - Security related label Aug 15, 2022
@SWvheerden SWvheerden moved this to In Progress in Tari Esme Testnet Aug 15, 2022
@hansieodendaal hansieodendaal moved this from In Progress to In Review in Tari Esme Testnet Aug 15, 2022
stringhandler pushed a commit that referenced this issue Aug 16, 2022
@hansieodendaal
feat!: apply hashing api to the mmr (#4445)
d6bab2f 
Description
---
Partial fulfillment for #4395:
- Added hashing API to the MMR by virtue of forcing the hashing type to be `D: Digest + DomainDigest` instead of only `D: Digest` at the lower level MMR methods and functions.
- base_layer/mmr/src/common.rs
- base_layer/mmr/src/merkle_mountain_range.rs
- base_layer/mmr/src/merkle_proof.rs
- base_layer/mmr/src/mutable_mmr.rs

Fixed cucumber function `const getTransactionOutputHash = function (output)`

Motivation and Context
---
Domain separated hashing as per the `tari_crypto` hashing API is needed for the MMR.

How Has This Been Tested?
---
- Passed unit tests
- Passed cucumber tests
Repository owner moved this from In Review to Done in Tari Esme Testnet Aug 18, 2022
@SWvheerden SWvheerden reopened this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
A-security Area - Security related
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SWvheerden @CjS77 @hansieodendaal