Skip to content

Commit

Permalink
feat: remove tracing_subscriber (#4906)
Browse files Browse the repository at this point in the history
Description
---
Remove tracing_subscriber and opentelemetry. 

Motivation and Context
---
Fixes #4651 
To my knowledge, this is not used anymore. There seems to be an update to this crate which solves the RUSTSEC warning, but the public API has changed, and it feels better to remove it, and then add it back if it is used or needed in future.

How Has This Been Tested?
---
Cargo build. The use of this feature was opt-in via the `--enable-tracing` arg, so was not run by default.
  • Loading branch information
stringhandler authored Nov 11, 2022
1 parent 55d1334 commit 956b279
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 298 deletions.
218 changes: 6 additions & 212 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions applications/tari_base_node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ tokio = { version = "1.20", features = ["signal"] }
tonic = "0.6.2"
tracing = "0.1.26"

# network tracing, rt-tokio for async batch export
opentelemetry = { version = "0.16", default-features = false, features = ["trace", "rt-tokio"] }
opentelemetry-jaeger = { version = "0.15", features = ["rt-tokio", "collector_client", "reqwest_collector_client"] }
tracing-opentelemetry = "0.15.0"
tracing-subscriber = "0.2.20"

# Metrics
tari_metrics = { path = "../../infrastructure/metrics", optional = true, features = ["server"] }

Expand Down
1 change: 0 additions & 1 deletion applications/tari_base_node/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ pub struct BaseNodeContext {
impl BaseNodeContext {
/// Waits for shutdown of the base node state machine and comms.
/// This call consumes the NodeContainer instance.
#[tracing::instrument(name = "base_node::wait_for_shutdown", skip(self))]
pub async fn wait_for_shutdown(self) {
self.state_machine().shutdown_signal().wait().await;
info!(target: LOG_TARGET, "Waiting for communications stack shutdown");
Expand Down
3 changes: 0 additions & 3 deletions applications/tari_base_node/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ pub(crate) struct Cli {
/// Create a default configuration file if it doesn't exist
#[clap(long)]
pub init: bool,
/// Enable tracing
#[clap(long, aliases = &["tracing", "enable-tracing"])]
pub tracing_enabled: bool,
/// This will rebuild the db, adding block for block in
// TODO: Should be a command rather
#[clap(long, alias = "rebuild_db")]
Expand Down
Loading

0 comments on commit 956b279

Please sign in to comment.