graphql: Convert empty UUID strings to NullUUID #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
approved these changes
Mar 12, 2024
mastercactapus
changed the title
ethan-haynes
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This update changes the use of
permission.UserIDtopermission.UserNullUUID(a new helper), which will pass NULL instead of an empty string to Postgres when the current context isn't owned by a user.Which issue(s) this PR fixes:
Fixes #3662
Describe any introduced user-facing changes:
N/A
Describe any introduced API changes:
N/A
Additional Info:
The issue turned out to have nothing to do with data races or GraphQL variables; instead, it was due to many store methods fetching favorites information (which is user-id specific) by passing
permission.UserID()(which returns a string) directly to the DB call.This broke when no UserID was associated with the context (as in GQL API keys, which are anonymous) because it would pass an empty string, which is not a valid UUID.
The fix was to switch to
uuid.NullUUID, which has a nullable state. A new helper method,permission.UserNullUUID,was added, and call sites were updated to use it rather thanUserID()for store methods.