Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apikey: allow omitting fixed queries #3464

Merged
merged 1 commit into from
Nov 21, 2023
Merged

apikey: allow omitting fixed queries #3464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions apikey/middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ func (Middleware) MutateOperationContext(ctx context.Context, rc *graphql.Operat
return nil
}

if rc.RawQuery == "" {
// Allow query to be omitted for API key requests,
// since they are always fixed to the key itself.
//
// The stored query hass been validated beforehand against
// the API key's embedded hash.
//
// This helps with things like key rotations, where the
// query may not be known to the client, or would otherwise
// be difficult to update.
rc.RawQuery = p.Query
}

if p.Query != rc.RawQuery {
return &gqlerror.Error{
Err: permission.Unauthorized(),
Expand Down