Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/service-metrics: Add usage graphs #3297

Merged
merged 24 commits into from
Nov 9, 2023
Merged

ui/service-metrics: Add usage graphs #3297

merged 24 commits into from
Nov 9, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Sep 21, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Adds graphs to visualize breakdown of Integration Key and Escalation Policy usage by target types.

Which issue(s) this PR fixes:
Fixes: #3057

Screenshots:
Service overview with filtered results for Integration Key Usage and Escalation Policy Usage
Screenshot 2023-11-06 at 1 39 35 PM

@KatieMSB KatieMSB marked this pull request as draft September 22, 2023 14:18
@KatieMSB KatieMSB removed the blocked label Oct 16, 2023
@KatieMSB KatieMSB marked this pull request as ready for review October 16, 2023 18:08
@KatieMSB KatieMSB marked this pull request as draft October 16, 2023 18:26
@KatieMSB KatieMSB changed the title ui/service-metrics: Add Service Metrics dashboard ui/service-metrics: Add usage graphs Nov 6, 2023
@KatieMSB KatieMSB marked this pull request as ready for review November 6, 2023 19:40
@github-actions github-actions bot added size/l and removed size/xl labels Nov 6, 2023
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KatieMSB KatieMSB merged commit 7b6a372 into master Nov 9, 2023
@KatieMSB KatieMSB deleted the admin-service-metrics branch November 9, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: Identify Services with Empty or Unreliable Escalation Policies
3 participants