auth/basic: add createBasicAuth and updateBasicAuth for managing Basic credentials via GraphQL
#3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
approved these changes
Jun 1, 2023
mastercactapus
changed the title
createBasicAuth and updateBasicAuth for managing Basic credentials via GraphQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Created two new mutations:
createBasicAuthandupdateBasicAuthin order to properly handle cases where basic auth is disabled or with accounts created via OICD/GITHUB and admins wish to create/update a user's basic auth.Additional checks for
auth/basic/db.gomethods to fail fast if basic auth is disabled.Added backend check to ensure that OldPassword is passed for non-admins and for the currentUser.
Which issue(s) this PR fixes:
part of #2667 prereq for #2991
Describe any introduced API changes:
Created two graphql mutation endpoints for create/update basic auth