Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golang auth dependancies #2949

Merged

Conversation

AlaricWhitney
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Updated all golang dependancies to the latest versions

Out of Scope:
Changing any code logic or evaluating which libraries are no longer needed.

Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some context on what changed with OIDC, github, and jose major version updates?

Since those are used for auth, and oidc+github will require manual validation locally, it would be helpful to know what changed with them.

@mastercactapus mastercactapus changed the title chore: update golang dependancies chore: update golang auth dependancies Apr 18, 2023
@AlaricWhitney
Copy link
Collaborator Author

Can you give some context on what changed with OIDC, github, and jose major version updates?

Since those are used for auth, and oidc+github will require manual validation locally, it would be helpful to know what changed with them.

KatieMSB
KatieMSB previously approved these changes Apr 21, 2023
@AlaricWhitney
Copy link
Collaborator Author

fixed merge conflicts. ready for review again.

@KatieMSB KatieMSB merged commit 0ff54ba into target:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants