Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/alerts: Convert alert step content to typescript #2939

Merged
merged 2 commits into from
Apr 18, 2023
Merged

ui/alerts: Convert alert step content to typescript #2939

merged 2 commits into from
Apr 18, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Apr 12, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts all step content components to typescript.

  • CreateAlertConfirm
  • CreateAlertInfo
  • CreateAlertListItem
  • CreateAlertReview
  • CreateAlertServiceListItem
  • CreateAlertServiceSelect

Part of #2318

@KatieMSB KatieMSB mentioned this pull request Apr 12, 2023
Closed
7 tasks
@AlaricWhitney
Copy link
Collaborator

@KatieMSB I think there's a Typescript error in this. If it's corrected I can review it.

@KatieMSB KatieMSB requested a review from AlaricWhitney April 17, 2023 15:49
@KatieMSB KatieMSB mentioned this pull request Apr 17, 2023
Open
@mastercactapus mastercactapus merged commit bb06b83 into master Apr 18, 2023
@mastercactapus mastercactapus deleted the alert-steps-tsx branch April 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@AlaricWhitney AlaricWhitney AlaricWhitney approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @AlaricWhitney @mastercactapus