-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/services: sort on call users by escalation step #2729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One thing of note we didn't consider: if there are no users on a step, it's omitted entirely -- probably okay, but I could also see users raising questions, "hey, why isn't step 2 showing up?"
We could pull in the escalation policy to display all steps, though we should probably add # of on-call users in each section as subtext or something for that as a hint.
Or maybe it's all the better as a follow-up if someone requests it.
@Forfold Thoughts?
Yeah that sounds like a good idea. Display the step if even if there's nobody on it. The accordion details could just have some typography like "Nobody on-call for this step" and there could be a warning icon rendered to the left of the Step # text in the accordion summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
make check
to catch common errors. Fixed any that came up.Description:
Updates the Service Details On Call Users list to have collapsable sections for each step for on call users.
Which issue(s) this PR fixes:
Fixes #2126
Screenshots:
