Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: sort on call users by escalation step #2729

Merged
merged 6 commits into from
Dec 20, 2022

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Dec 7, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Updates the Service Details On Call Users list to have collapsable sections for each step for on call users.

Which issue(s) this PR fixes:
Fixes #2126

Screenshots:
Screen Shot 2022-12-19 at 1 58 38 PM

mastercactapus
mastercactapus previously approved these changes Dec 8, 2022
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing of note we didn't consider: if there are no users on a step, it's omitted entirely -- probably okay, but I could also see users raising questions, "hey, why isn't step 2 showing up?"

We could pull in the escalation policy to display all steps, though we should probably add # of on-call users in each section as subtext or something for that as a hint.

Or maybe it's all the better as a follow-up if someone requests it.

@Forfold Thoughts?

@Forfold
Copy link
Contributor

Forfold commented Dec 15, 2022

Yeah that sounds like a good idea. Display the step if even if there's nobody on it. The accordion details could just have some typography like "Nobody on-call for this step" and there could be a warning icon rendered to the left of the Step # text in the accordion summary

Copy link

@johnmarksilly johnmarksilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@mastercactapus mastercactapus merged commit a61b4e5 into master Dec 20, 2022
@mastercactapus mastercactapus deleted the order-users-escalation-step branch December 20, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort on call users in order of escalation
4 participants