-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: playwright mvp #2608
Merged
Merged
dev: playwright mvp #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-tvu
reviewed
Sep 12, 2022
KatieMSB
approved these changes
Sep 12, 2022
KatieMSB
previously approved these changes
Sep 13, 2022
KatieMSB
previously approved these changes
Sep 13, 2022
KatieMSB
approved these changes
Sep 13, 2022
tony-tvu
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds playwright as a test framework for integration tests.
--engine-cycle-time
flagmake start-integration
can be used to start background processes to speed up test runs during devWhich issue(s) this PR fixes:
Closes #2589
Out of Scope:
test-results/
but not made available in CI yetAdditional Info:
yarn playwright test
ormake playwright-run
make test-integration
has been updated to include both playwright and cypress testsCold start run time:
With
make start-integration
running: