Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: playwright mvp #2608

Merged
merged 19 commits into from
Sep 13, 2022
Merged

dev: playwright mvp #2608

merged 19 commits into from
Sep 13, 2022

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Sep 1, 2022

Description:
This PR adds playwright as a test framework for integration tests.

  • Engine cycle time is now configurable via --engine-cycle-time flag
  • Updated header tags and menuitem roles in UI for parity between mobile & wide
  • First test adds and validates an email contact method
  • make start-integration can be used to start background processes to speed up test runs during dev
  • admin and user sessions are available for tests as a starting point

Which issue(s) this PR fixes:
Closes #2589

Out of Scope:

  • Not migrating any existing Cypress tests
  • Failed-test traces are generated in test-results/ but not made available in CI yet

Additional Info:

  • You can run the playwright tests with yarn playwright test or make playwright-run
  • make test-integration has been updated to include both playwright and cypress tests

Cold start run time:

$ make playwright-run
  ✓  1 [chromium-wide] › email-cm.spec.ts:10:1 › EMAIL contact method (3s)
  ✓  2 [chromium-mobile] › email-cm.spec.ts:10:1 › EMAIL contact method (3s)

  2 passed (12s)
Done in 12.61s.

With make start-integration running:

$ make playwright-run
  ✓  1 [chromium-mobile] › email-cm.spec.ts:10:1 › EMAIL contact method (4s)
  ✓  2 [chromium-wide] › email-cm.spec.ts:10:1 › EMAIL contact method (3s)


  2 passed (4s)
Done in 4.69s.

KatieMSB
KatieMSB previously approved these changes Sep 13, 2022
KatieMSB
KatieMSB previously approved these changes Sep 13, 2022
@mastercactapus mastercactapus merged commit f528819 into master Sep 13, 2022
@mastercactapus mastercactapus deleted the playwright-mvp branch September 13, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: add Playwright as a testing tool
3 participants