Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/worker: add loading status to worker #2542

Merged
merged 8 commits into from
Aug 18, 2022
Merged

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Aug 3, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This pr adds adds a returned loading status to the useWorker hook and updates where workers are used to display spinners while loading.

Before
After

Which issue(s) this PR fixes:
Closes #2519

@mastercactapus mastercactapus self-requested a review August 8, 2022 14:49
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested 👍

@KatieMSB KatieMSB merged commit d012eb4 into master Aug 18, 2022
@KatieMSB KatieMSB deleted the worker-loading-status branch August 18, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: add spinners to components loading data with webworkers
3 participants