Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: use autosizer for rechart graphs #2529

Merged
merged 1 commit into from
Aug 2, 2022
Merged

ui: use autosizer for rechart graphs #2529

merged 1 commit into from
Aug 2, 2022

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Adds new AutoSizer for resizing rechart graphs on window resize.

tony-tvu
tony-tvu approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's anything to worry about but I'm seeing these error logs without strict mode. Otherwise LGTM.
logs

@mastercactapus mastercactapus merged commit 925767d into master Aug 2, 2022
@mastercactapus mastercactapus deleted the graph-autosize branch August 2, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@tony-tvu tony-tvu tony-tvu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @tony-tvu