-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services: add maintenance mode option to snooze alert notifications #2512
Conversation
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com>
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
… disable escalating if maintenance mode exists Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com> Co-authored-by: mastercactapus <mastercactapus@gmail.com>
…on cancel Co-authored-by: tony-tvu <Tony.T.Vu@outlook.com> Co-authored-by: mastercactapus <mastercactapus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the escalation code, I had a couple of thoughts, what's the expected behavior when escalating multiple alerts when only one or two are in maintenance mode?
When we talked about it, we figured an error should be returned, but the method signatures suggest we should instead have it do nothing, as it's supposed to return only the alerts that were escalated.
escalateAlerts(input: [1]) -> []
As it stands, if one alert is for a service in maintenance mode, all will fail with a generic error. It's more a limitation of how the API is set up currently.
I'll reach out to chat more about it
totally did not think of this use case, we were thinking in terms of alert 1: active service escalateAlerts(ids: [1, 2]) returns
|
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Closes #2490
Adds a button to configure maintenance mode for 1, 2, or 4 hours from any service details page. All notifications during this time period will be silenced, and escalations will not be processed. Any incoming alerts will still be created (snoozing integration keys out of scope).
After maintenance mode ends, alerts will be sent out as normal to the on-call user.
Screenshots:
Service details maintenance mode button
Maintenance mode dialog
Maintenance mode notice banners
Escalate alert GraphQL error while in maintenance mode