Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/alert-metrics: add avgTimeToAck and avgTimeToClose chart #2347

Merged
merged 62 commits into from
Jun 15, 2022

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Apr 28, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This pr adds new alert metrics chart for visualizing time to acknowledge and time to close averages for daily alerts.

Which issue(s) this PR fixes:
Closes #2313

Screenshots:
Light Mode
Screen Shot 2022-05-05 at 12 21 38 PM
Dark Mode
Screen Shot 2022-05-05 at 12 21 26 PM

Describe any introduced API changes:

# adds new metrics to AlertDataPoint type
type AlertDataPoint {
  timestamp: ISOTimestamp!
  alertCount: Int!
  avgTimeToAck: ISODuration # only null if alertCount is 0
  avgTimeToClose: ISODuration # only null if alertCount is 0
}

@KatieMSB KatieMSB marked this pull request as ready for review May 4, 2022 23:48
@mastercactapus mastercactapus self-requested a review May 5, 2022 18:03
mastercactapus
mastercactapus previously approved these changes May 5, 2022
mastercactapus
mastercactapus previously approved these changes May 11, 2022
mastercactapus
mastercactapus previously approved these changes Jun 8, 2022
@mastercactapus
Copy link
Member

approving just to test in CI; time/space code will be moved to it's own PR before merging

mastercactapus
mastercactapus previously approved these changes Jun 8, 2022
mastercactapus
mastercactapus previously approved these changes Jun 15, 2022
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit f6418cc into master Jun 15, 2022
@mastercactapus mastercactapus deleted the alert-metrics-averages branch June 15, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alert metrics: add chart to display time-to-acknowledge and time-to-close
4 participants