graphql: add debugMessages query #2052
Conversation
graphql2/graphqlapp/query.go
Outdated
| return "", nil | ||
| } | ||
|
|
||
| return notification.Dest{Type: obj.Dest.Type, Value: obj.Status.SrcValue}.String(), nil |
There was a problem hiding this comment.
I don't think we should rely on the destination interface for formatting the source value. I sent a test message and got the following response:
I would expect source to be the Twilio FromNumber
There was a problem hiding this comment.
Good catch, we should use the same formatting as destination and keep it as an empty string if value is blank.
| *s = StateFailedPerm | ||
| case "stale": | ||
| *s = StateFailedTemp | ||
| default: |
There was a problem hiding this comment.
Is this switch missing the bundled case?
There was a problem hiding this comment.
Ooh that's a good call, we may need to add a new state. Normally "bundled" messages aren't processed at all, but they would still be returned here.
Co-authored-by: David Talbot <david.talbot@target.com>
|
While functionally validating I am seeing some alertIDs being returned as null. I don't think
|
|
@arurao only alert notifications and bundles have an alert ID, test, validation, on-call, etc.. don't. Alert status updates should but don't due to an unrelated bug |
Description:
Adds a
debugMessagesquery that can be used by an admin to retrieve a list of recent messages from theoutgoing_messagestable.