Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote for google chat #223

Merged
merged 3 commits into from
Apr 5, 2022
Merged

feat: remote for google chat #223

merged 3 commits into from
Apr 5, 2022

Conversation

justmiles
Copy link
Contributor

Proposed change

Hi team! This PR adds initial support for Google Chat (#221). There's is an accompanying pull request for documentation here: target/flottbot-docs#56

Any feedback is appreciated!

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@wass3r
Copy link
Collaborator

wass3r commented Feb 1, 2022

Thanks a ton for the PR(s). Love the doc PR too. This looks great at a glance. Will do a deeper dive including set up and running this sometime this week. Thanks for taking the time!

@coveralls
Copy link

coveralls commented Feb 2, 2022

Pull Request Test Coverage Report for Build 2087638035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1782300583: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@oCephaso
Copy link

Thanks a ton for the PR(s). Love the doc PR too. This looks great at a glance. Will do a deeper dive including set up and running this sometime this week. Thanks for taking the time!

Has there been any progress on this PR? My company is interested in using Flottbot and remote would be good for our Google implementation

Thanks

@wass3r
Copy link
Collaborator

wass3r commented Mar 17, 2022

Sorry for the delay. Had a few personal things come up. I did one attempt at setting this up some time ago with the docs and didn't make it all the way. I don't think it was an issue with the docs though. Likely, user error. I will give it another shot. In the meantime, if you don't mind getting the branch up-to-date, i will pause on the other PRs until this is resolved.

@wass3r
Copy link
Collaborator

wass3r commented Mar 17, 2022

ah yes. i got stuck on "Google Chat API is only available to Google Workspace users" - will try and see how to get that resolved

wass3r
wass3r previously approved these changes Mar 25, 2022
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not able to test without a workspace account, but the implementation looks fine - thanks for the work.

@wass3r wass3r added googlechat google chat remote specific waiting for author labels Mar 25, 2022
@justmiles
Copy link
Contributor Author

justmiles commented Apr 2, 2022

In the meantime, if you don't mind getting the branch up-to-date, i will pause on the other PRs until this is resolved.

@wass3r - this is up to date now.

@justmiles
Copy link
Contributor Author

Ran into an issue with unknown message types, but resolved it with 543ca20.

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again, also for your patience 🙇🏼

@wass3r wass3r merged commit fd20605 into target:main Apr 5, 2022
@wass3r wass3r mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
googlechat google chat remote specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants