Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): detach logger from Bot #210

Merged
merged 1 commit into from
Nov 27, 2021
Merged

refactor(log): detach logger from Bot #210

merged 1 commit into from
Nov 27, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 25, 2021

❤ THANKS FOR HELPING OUT :D

Proposed change

Set up log globally to avoid passing Bot for just logging. Also includes change that closes #187

Additionally:

  • moves Bot constructor into models/bot.go
  • moves a utility function (IsSet) into utils/
  • injects logger into Slack Socket Mode

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1503825992

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1483383316: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@wass3r wass3r merged commit f47b01d into main Nov 27, 2021
@wass3r wass3r deleted the refactor/log branch November 27, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection refused on Slack connection, intermittently
2 participants