updated converged status to self.converged throughout workflow #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
*beep* *bop* 7 G004 [ ] Logging statement uses f-string
6 W293 [*] Blank line contains whitespace
1 TD005 [ ] Missing issue description after `TODO`
1 E999 [ ] SyntaxError: Simple statements must be separated by newlines or semicolons
Complete output(might be large): .github/workflows/lfs-cache.yml:1:12: E999 SyntaxError: Simple statements must be separated by newlines or semicolons
.github/workflows/lfs-cache.yml:38:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:50:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:58:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:63:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:68:1: W293 [*] Blank line contains whitespace
.github/workflows/lfs-cache.yml:72:1: W293 [*] Blank line contains whitespace
tardis/workflows/simple_tardis_workflow.py:230:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:451:17: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:172:13: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:212:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:16:3: TD005 Missing issue description after `TODO`
tardis/workflows/v_inner_solver.py:180:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:207:17: G004 Logging statement uses f-string
tardis/workflows/v_inner_solver.py:315:17: G004 Logging statement uses f-string
Found 15 errors.
[*] 6 fixable with the `--fix` option.
|
andrewfullard
approved these changes
Feb 3, 2025
jvshields
approved these changes
Feb 3, 2025
|
So that tests can run, please push an empty commit with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
- Coverage 69.54% 69.17% -0.37%
==========================================
Files 228 228
Lines 16429 16429
==========================================
- Hits 11425 11365 -60
- Misses 5004 5064 +60 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfixThroughout the workflow notebooks, the converged variable was a temporary variable, so it could not update properly. I went through simple_tardis_workflow.py, standard_tardis_workflow.py, and v_inner_solver.py and changed every 'converged' variable to 'self.converged'.
@DeerWhale