Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing sponsors and credits pages of documentation #1656

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented Jun 17, 2021

Description

  • Adds descriptions of what each sponsor does for us into the sponsors page
  • Acknowledges GitHub and NUMFocus on the credits page

How has this been tested?

  • Testing pipeline.
  • Other.
    Documentation built locally.

Examples

Here are the two relevant pages:
https://smithis7.github.io/tardis/branch/sponsor_description_doc/sponsors.html
https://smithis7.github.io/tardis/branch/sponsor_description_doc/credits.html

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@isaacgsmith isaacgsmith changed the title Editing Editing sponsors and credits pages of documentation Jun 17, 2021
@isaacgsmith isaacgsmith reopened this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1656 (05088f6) into master (b69b093) will not change coverage.
The diff coverage is n/a.

❗ Current head 05088f6 differs from pull request most recent head fe7bf86. Consider uploading reports for the commit fe7bf86 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1656   +/-   ##
=======================================
  Coverage   61.93%   61.93%           
=======================================
  Files          62       62           
  Lines        5729     5729           
=======================================
  Hits         3548     3548           
  Misses       2181     2181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69b093...fe7bf86. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@isaacgsmith isaacgsmith requested a review from epassaro June 17, 2021 17:59
Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumFOCUS should be written as NumFOCUS and it should reference the small development grant. What did GitHub do for us again? Could you add that in?

@wkerzendorf wkerzendorf merged commit d2bab39 into tardis-sn:master Jun 23, 2021
@isaacgsmith isaacgsmith deleted the sponsor_description_doc branch June 23, 2021 15:37
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* sponsors page and credits

* [build docs]

* updated credits page to reflect how NumFOCUS sponsors TARDIS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants