Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to get constant density? broken? #160

Merged
merged 1 commit into from
Jul 2, 2014

Conversation

wkerzendorf
Copy link
Member

What has become of:

        density:
            type : uniform
            value: 1.e-14 g/cm3

we want that to work e.g. for the comparison with syn++. But that type of density doesn't work now. @wkerzendorf @mklauser I assume this got lost (or the way we specify it changed?) as a result of the config validator changes?

@ssim ssim added easy labels Jun 30, 2014
@wkerzendorf
Copy link
Member

@ssim, have you tried it? Is there an error that occured? I thought it should still work.

@ssim
Copy link
Contributor Author

ssim commented Jun 30, 2014

@wkerzendorf Yes, it just complains about not understanding:

/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pandas/io/excel.py:626: UserWarning: Installed openpyxl is not supported at this time. Use >=1.6.1 and <2.0.0.
  .format(openpyxl_compat.start_ver, openpyxl_compat.stop_ver))
ERROR: ValueError: Wrong container type in the configuration! The container is uniform but only ['branch85_w7', 'exponential', 'power_law'] are allowed containers. [['model', 'structure', 'density']] [tardis.io.config_validator]
Traceback (most recent call last):
  File "/Users/stuartsim/Tardis/tardis/scripts//tardis", line 62, in <module>
    tardis_config = config_reader.Configuration.from_yaml(args.config_fname)
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_reader.py", line 736, in from_yaml
    return cls.from_config_dict(yaml_dict, test_parser=test_parser)
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_reader.py", line 777, in from_config_dict
    config_dict).get_config()
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1161, in __init__
    self.__parse_config(configuration_definition, input_configuration)
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1337, in __parse_config
    self.__conf_o, self.__conf_v = recursive_parser(default_configuration, configuration, [])
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1323, in recursive_parser
    tmp_conf_ob[k], tmp_conf_val[k] = recursive_parser(v, configuration, path + [k])
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1323, in recursive_parser
    tmp_conf_ob[k], tmp_conf_val[k] = recursive_parser(v, configuration, path + [k])
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1309, in recursive_parser
    ccontainer = Container(top_default, container_conf, container_path=path)
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1001, in __init__
    container_dict[nitem], nitem, self.__container_path + [nitem])
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 1093, in parse_container_items
    ccontainer = Container(top_default, container_conf, container_path=full_path)
  File "/Users/stuartsim/Tardis/tardis/build/lib.macosx-10.9-x86_64-2.7/tardis/io/config_validator.py", line 949, in __init__
    self.__container_path))
ValueError: Wrong container type in the configuration! The container is uniform but only ['branch85_w7', 'exponential', 'power_law'] are allowed containers. [['model', 'structure', 'density']]

@wkerzendorf
Copy link
Member

@ssim I see, yes that is an oversight, can you post the configuration file?

@ssim
Copy link
Contributor Author

ssim commented Jul 1, 2014

@wkerzendorf
Copy link
Member

@ssim I think that should fix it (I used your file to test it). If tests are successful merge.

@ssim
Copy link
Contributor Author

ssim commented Jul 2, 2014

Thanks! It passes the Travis stuff, so I'll merge now and check it works for me too!

ssim added a commit that referenced this pull request Jul 2, 2014
@ssim ssim merged commit 0a7d2a9 into tardis-sn:master Jul 2, 2014
@ssim
Copy link
Contributor Author

ssim commented Jul 2, 2014

Yes - it runs fine now! @wkerzendorf
Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants