Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new template to release pipeline #1308

Merged
merged 5 commits into from
Oct 12, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Sep 25, 2020

Description

Just a quick review of release-pipeline.yml (make releases of TARDIS on GitHub every week).

  • Apply the new TARDIS pipeline template. The pipeline now is easier to understand and mantain.
  • Use of Azure syntax (preferred use of single quotes, etc).
  • Do not make a release if no new changes were merged to the TARDIS master branch (by removing always: true parameter).
  • Change the cron schedule expression to the not-so-less arbitrary 0 0 * * 0 (Sun 00:00 UTC).
  • Update documentation.

Motivation and Context

We're currently reviewing our existing pipelines.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1308 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   81.50%   81.57%   +0.07%     
==========================================
  Files          46       46              
  Lines        3784     3799      +15     
==========================================
+ Hits         3084     3099      +15     
  Misses        700      700              
Impacted Files Coverage Δ
tardis/tardis/io/config_reader.py 86.02% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c5707...a5be6db. Read the comment docs.

@epassaro epassaro marked this pull request as draft September 25, 2020 15:39
@epassaro epassaro marked this pull request as ready for review September 29, 2020 20:58
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that the name is now 'Weekly release' rather than 'Weekly build'. Are we considering these official full TARDIS releases?

@epassaro
Copy link
Member Author

I notice that the name is now 'Weekly release' rather than 'Weekly build'. Are we considering these official full TARDIS releases?

This pipeline was created in order to make automatic GitHub releases every 1 or 2 weeks (or monthly) to be released in conda-forge as dev releases.

conda-forge has a new way for dev releases that are no longer published on the main channel. I don't know if we're planning to release stable versions or just keep using this CI/CD approach for everything @wkerzendorf.

Publishes a new release of TARDIS every sunday at 22:30 UTC.

.. warning :: Fails if no new commits were merged since the last release.
Publishes a new release of TARDIS every sunday at 00:00 UTC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Publishes a new release of TARDIS every sunday at 00:00 UTC.
Publishes a new release of TARDIS every Sunday at 00:00 UTC.

@wkerzendorf wkerzendorf merged commit 4cee3b2 into tardis-sn:master Oct 12, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Initial commit

* Minor changes

* Change cron schedule expression

* Remove old release page

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants