Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from PR 248 #251

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix regression from PR 248 #251

merged 1 commit into from
Sep 18, 2023

Conversation

humphd
Copy link
Collaborator

@humphd humphd commented Sep 18, 2023

In #248 I caused a regression, by getting the messages before adding the current prompt from the user. I need to do it after.

I've updated this code so that it separates the logic for getting the messages for checking if the last one was a Human Message from the part where it sends the new messages.

NOTE: by default, all options to .messages({...}) are true, so I'm removing unnecessary true values in this code to simplify.

To test this, you should be able to get the LLM to respond to a query. Without it, it will ignore what you just wrote.

@humphd humphd merged commit a7fcec8 into main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant