Add TSGI Layer Between Router and Server #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Distinct subfolders nginx_server/ server/ for NGINX and builtin servers. 2. Extract common (not specific to particular tsgi adapter) code to http/tsgi.lua.
As it is used in both builtin- and nginx- servers, its extracted to common http/tsgi module.
README.md
Outdated
| @@ -208,11 +208,13 @@ end | |||
| * `req.headers` - normalized request headers. A normalized header | |||
| is in the lower case, all headers joined together into a single string. | |||
| * `req.peer` - a Lua table with information about the remote peer | |||
| (like `socket:peer()`). | |||
| (like `socket:peer()`). **NOTE**: not available when using NGINX TSGI | |||
| adapter. | |||
There was a problem hiding this comment.
Хотелось бы оставить socket:peer() частично рабочим.
Пользователь может смотреть адрес клиента - логировать, анализировать, етц.
Michael Filonenko, [13 May 2019 at 11:20:51]:
логирование, и вдруг поднимут два нжинкса, захотят посмотреть кто говнит
|
Please add doc file with TSGI spec |
host and port are extracted via box.session.peer(). family, type and protocol are hardcoded.
filonenko-mikhail
approved these changes
May 16, 2019
knazarov
pushed a commit
that referenced
this pull request
Oct 4, 2019
Changes done: 1. decompose the code into modular pieces 2. decouple router and server parts 3. introduce nginx as possible Web Server via TSGI adapter 4. enable router tests on NGINX Note: this change breaks connection stealing.
Closed
ligurio
pushed a commit
that referenced
this pull request
Oct 27, 2021
Changes done: 1. decompose the code into modular pieces 2. decouple router and server parts 3. introduce nginx as possible Web Server via TSGI adapter 4. enable router tests on NGINX Note: this change breaks connection stealing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Read TSGI Spec Draft for details on TSGI layer.
I consider this PR as an alpha version of tarantool/http 2.0: new features, more breaking changes may be introduced.
Changes
test_locally.sh.TODO