dashboard: use fill(null) in InfluxQL requests #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-154-vinyl-panels
branch
from
b2a43e3 to
d2194c7
Compare
This patch replaces fill(none) with fill(null) in dashboards InfluxQL requests. After this patch, all panels with non-derivative requests will show the gap in metrics for an interval if there were no metrics for this interval. Before this patch, they had displayed a straight line connecting border values in the area. Derivative requests will still display a straight line [1]. There is a workaround to make derivative requests result consistent with non-derivative one, but it makes query more complicated both in terms of readability and performance, so it's not worth it. 1. influxdata/influxdb#7185 Closes #23
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-23-fill-null
branch
from
a6c0634 to
eae1574
Compare
DifferentialOrange
changed the base branch from
DifferentialOrange/gh-154-vinyl-panels
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces fill(none) with fill(null) in dashboards InfluxQL requests. After this patch, all panels with non-derivative requests will show the gap in metrics for an interval if there were no metrics for this interval. Before this patch, they had displayed a straight line connecting border values in the area. Derivative requests will still display a straight line [1]. There is a workaround to make derivative requests result consistent with non-derivative one, but it makes query more complicated both in terms of readability and performance, so it's not worth it.
Closes #23