Fix nan crud.stats latency #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
changed the base branch from
master
to
DifferentialOrange/gh-284-tolerated-error-lost
no1seman
reviewed
May 17, 2022
Totktonada
reviewed
May 17, 2022
Totktonada
reviewed
May 17, 2022
Totktonada
reviewed
May 17, 2022
Base automatically changed from
DifferentialOrange/gh-284-tolerated-error-lost
to
master
May 18, 2022 08:27
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-286-age-nan
branch
3 times, most recently
from
8fe6dbb to
4429a00
Compare
The main motivation of making these parameters configurable is to be able to write time-adequate test cases for #286 issue, but they may be useful in getting rid of #286 effect at all or in quantile time window calibration. After this patch, statistics summary quantile aging params `age_bucket_count` and `max_age_time` [1] could be configured: crud.cfg{ stats_quantile_age_bucket_count = 3, stats_quantile_max_age_time = 30, } Only type validation is conducted in crud.cfg, every other validation is performed by metrics itself. 1. https://www.tarantool.io/ru/doc/latest/book/monitoring/api_reference/#summary Part of #286
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-286-age-nan
branch
2 times, most recently
from
2e5113d to
85e6ac8
Compare
Totktonada
reviewed
May 18, 2022
Totktonada
approved these changes
May 18, 2022
Totktonada
reviewed
May 18, 2022
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-286-age-nan
branch
3 times, most recently
from
35ac849 to
4a76d92
Compare
Add separate quantile (`latency_quantile_recent`) and average ( `latency_average`) fields to `crud.stats()` output. `latency` field and tarantool/metrics output remains unchanged. Before this patch, `latency` displayed `latency_quantile_recent` or `latency_average` and there wasn't any was to see pre-computed average if quantiles are enabled. But it may be useful if quantile is `nan`. Quantiles may display `-nan` if there were no observations for a several ages. Such behavior is expected [1] and valid: for example, Grafana should ignore such values and they will be displayed as `No data` for a window when there wasn't any requests. 1. tarantool/metrics#303 Closes #286
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-286-age-nan
branch
from
4a76d92 to
c66d330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: fix quantile tolerated error description
stats: make quantile age params configurable
The main motivation of making these parameters configurable is to be
able to write time-adequate test cases for #286 issue, but they may be
useful in getting rid of #286 effect at all or in quantile time window
calibration.
After this patch, statistics summary quantile aging params
age_bucket_countandmax_age_time[1] could be configured:Only type validation is conducted in crud.cfg, every other validation is
performed by metrics itself.
stats: separate quantile and average fields
Add separate quantile (
latency_quantile_recent) and average (latency_average) fields tocrud.stats()output.latencyfield andtarantool/metrics output remains unchanged.
Before this patch,
latencydisplayedlatency_quantile_recentorlatency_averageand there wasn't any was to see pre-computed averageif quantiles are enabled. But it may be useful if quantile is
nan.Quantiles may display
-nanif there were no observations for a severalages. Such behavior is expected [1] and valid: for example, Grafana
should ignore such values and they will be displayed as
No datafora window when there wasn't any requests.
I didn't forget about
Closes #286