Isaacs/better testdir symlinks #704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the fixture cleanup _always_ run after any user-supplied teardown functions (which was ambiguous before), and removes using the async form of `rimraf` so that it can retry with backoff if the directories are locked. Fixes: #677
isaacs
added a commit
to tapjs/libtap
that referenced
this pull request
Feb 16, 2021
This makes the fixture cleanup _always_ run after any user-supplied teardown functions (which was ambiguous before), and removes using the async form of `rimraf` so that it can retry with backoff if the directories are locked. Note: in libtap, this requires adding an async recursive removal function to settings. PR-URL: tapjs/tapjs#704
isaacs
added a commit
to tapjs/libtap
that referenced
this pull request
Feb 16, 2021
This makes the fixture cleanup _always_ run after any user-supplied teardown functions (which was ambiguous before), and removes using the async form of `rimraf` so that it can retry with backoff if the directories are locked. Note: in libtap, this requires adding an async recursive removal function to settings. PR-URL: tapjs/tapjs#704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nlf