[Deps] update 'glob' #612
Closed
[Deps] update 'glob' #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Duplicate of #611; and as you can see, tests do not pass. |
|
OK, will migrate to vitest. |
"glob": "^7.2.3", (the current version without this PR)
# npm run test
391 passing (26s)
5 pending"glob": "^8.1.0",
# npm run test
391 passing (26s)
5 pending"glob": "^9.3.5",
# npm run test
385 passing (26s)
5 pending
6 failingAs you can see, tests do pass on version 8. |
|
@lloydjatkinson not on every version of node that tape supports. |
|
Are any of those old node versions not EOL? |
|
EOL status is irrelevant; dropping support for any node version is a breaking change, and eliminating a transitive deprecation warning is barely enough justification for a patch release, let alone a major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
globdependency. All tests pass with 8.x.x, and fail on any newer versions.