Add "onFailure" listener to test harness. #408
Conversation
lib/results.js
Outdated
| else self.fail ++ | ||
| else { | ||
| self.emit("fail"); | ||
| self.fail ++; |
There was a problem hiding this comment.
could the sync emission fail? it seems like we should increment self.fail first.
|
@ljharb , thanks for the feedback! I'm still having trouble coming up with a way of testing for the failure event that doesn't cause the test to fail. |
test/onFailure.js
Outdated
| var tape = require("../"); | ||
| const t = tap.test("on failure", {timeout: 1000}, function (tt) { | ||
| tt.plan(1); | ||
| tape.onFailure(function() { |
There was a problem hiding this comment.
could this add an onFinish listener as well that fails?
There was a problem hiding this comment.
@ljharb, i don't quite understand your comment.
This test does, in fact, fail. That is, for the "outer test" to pass, the "inner test" must fail, and this failure propagates. I wonder if you, or anyone else might have an idea about how to get around this?
There was a problem hiding this comment.
Sorry, what I mean is, add something like tape.onFinish(function () { tt.fail(); })
There was a problem hiding this comment.
@ljharb I couldn't quite get the method that you mentioned to work, though I was able to get a test working after a while. Hopefully that does it. Thanks again for the help and feedback!
johnhenry
changed the title
|
Is anything else needed for this pull request? |
|
@lastmjs, i think this is ready, but I'm happy to make any changes that would get this into the next release soon. |
- [New] use `process.env.NODE_TAPE_OBJECT_PRINT_DEPTH` for the default object print depth (#420) - [New] Add "onFailure" listener to test harness (#408) - [Fix] fix stack where actual is falsy (#400) - [Fix] normalize path separators in stacks (#402) - [Fix] fix line numbers in stack traces from inside anon functions (#387) - [Fix] Fix dirname in stack traces (#388) - [Robustness] Use local reference for clearTimeout global (#385) - [Deps] update `function-bind`
Adds an onFinish listener to test harness as discussed here: #367 (comment)