Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharded Redis #133

Closed
shmish111 opened this issue May 7, 2015 · 6 comments
Closed

Sharded Redis #133

shmish111 opened this issue May 7, 2015 · 6 comments

Comments

@shmish111
Copy link

I appreciate that this functionality would be superseded by Redis Cluster on Redis 3 but for those of us who will be using Redis < 3.0 for a while has anyone looked at implementing something like ShardedJedis? If not, would a PR be accepted if I work on it?

@ptaoussanis
Copy link
Member

Hi David,

Now that Cluster's officially out with Redis 3, other sharding approaches are basically obsolete.

For Cluster support - most of the hairy internals are already in Carmine to support Cluster in a way that works well with Carmine's own features (request pipelining and parsers, etc.). There's still some work needed, and that'll definitely need to come from PR since I'm short on time lately and don't have any need for Cluster myself.

There's a cluster ns with an old (+ possibly out-of-date) sketch of the work still needed. I'd suggest starting there if you or anyone else were interested in investigating a Cluster PR.

Cheers :-)

@ptaoussanis
Copy link
Member

I appreciate that this functionality would be superseded by Redis Cluster on Redis 3 but for those of us who will be using Redis < 3.0 for a while

Sorry, I somehow missed this context. Is there a specific reason you would be hesitant to switch to Redis 3? It's a non-breaking upgrade in the vast majority of cases I believe.

@shmish111
Copy link
Author

Because going from our current Jedis wrapper with sharding to carmine and
redis cluster all in one go will be scary but I suppose it's probably for
the best.

On Thu, May 7, 2015 at 1:19 PM, Peter Taoussanis notifications@github.com
wrote:

I appreciate that this functionality would be superseded by Redis Cluster
on Redis 3 but for those of us who will be using Redis < 3.0 for a while

Sorry, I somehow missed this context. Is there a specific reason you would
be hesitant to switch to Redis 3? It's a non-breaking upgrade in the vast
majority of cases I believe.


Reply to this email directly or view it on GitHub
#133 (comment).

@ptaoussanis
Copy link
Member

Ahh, gotcha. Does Jedis have support for Cluster yet? Perhaps you could switch to Jedis+Cluster as a first step?

@shmish111
Copy link
Author

Nope :( Plus I do not like it or the wrapper we use (an old in-house one)
so I don't want to make our code even more dependent on it.

On Thu, May 7, 2015 at 1:23 PM, Peter Taoussanis notifications@github.com
wrote:

Ahh, gotcha. Does Jedis have support for Cluster yet? Perhaps you could
switch to Jedis+Cluster as a first step?


Reply to this email directly or view it on GitHub
#133 (comment).

@ptaoussanis
Copy link
Member

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants