Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanup for Tanya #2

Merged
merged 1 commit into from
Dec 30, 2020
Merged

More cleanup for Tanya #2

merged 1 commit into from
Dec 30, 2020

Conversation

DomHeinzeller
Copy link

Cleanup work in lndp_apply_perts.F90: define zs_ruc locally, remove trailing whitespaces, pass only one value lsoil from wrapper.

@climbfuji
Cleanup work in lndp_apply_perts.F90: define zs_ruc locally, remove t…
ac026f6 
…railing whitespaces, pass only one value lsoil from wrapper
@DomHeinzeller
Copy link
Author

@tanyasmirnova please merge this PR when you get the chance. Thanks!

tanyasmirnova
tanyasmirnova reviewed Dec 30, 2020
View reviewed changes
Copy link
Owner

@tanyasmirnova tanyasmirnova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dom, we forgot about Noah-MP. Everything that we do for the Noah LSM should work for Noah-MP because it has the same vertical structure in soil domain. Should we add NOah-MP option before merging?

@climbfuji
Copy link

Dom, we forgot about Noah-MP. Everything that we do for the Noah LSM should work for Noah-MP because it has the same vertical structure in soil domain. Should we add NOah-MP option before merging?

I wouldn't, honestly. We are not testing it, and untested code is by definition broken.

@tanyasmirnova
Copy link
Owner

ok, sounds good. Then I'll merge the code.

@tanyasmirnova tanyasmirnova merged commit 81d091f into tanyasmirnova:gsl_landstoch_withruc Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasmirnova tanyasmirnova tanyasmirnova left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DomHeinzeller @climbfuji @tanyasmirnova