Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

fix controls not showing on Android lock screen #227

Merged
merged 1 commit into from
Feb 1, 2019
Merged

fix controls not showing on Android lock screen #227

merged 1 commit into from
Feb 1, 2019

Conversation

lufinkey
Copy link
Contributor

@lufinkey lufinkey commented Feb 1, 2019

Fixes an issue where controls wouldn't show on the lock screen on Android ( Issue #192 )

@tanguyantoine tanguyantoine merged commit 51a6fc2 into tanguyantoine:master Feb 1, 2019
github-actions bot pushed a commit that referenced this pull request Feb 1, 2019
@semantic-release-bot
chore(release): 0.9.8 [skip ci]
a602310 
## [0.9.8](v0.9.7...v0.9.8) (2019-02-01)

### Bug Fixes

* controls not showing on Android lock screen ([#227](#227)) ([51a6fc2](51a6fc2))
* remove extra pause event related to app suspension in IOS10+ ([6ee2a86](6ee2a86))
@tanguyantoine
Copy link
Owner

release under 0.9.8

@Guichaguri Guichaguri mentioned this pull request Feb 8, 2019
Closed
tanguyantoine added a commit that referenced this pull request Feb 9, 2019
@tanguyantoine
Revert "fix: controls not showing on Android lock screen (#227)"
8befa03 
This reverts commit 51a6fc2.
@tanguyantoine tanguyantoine mentioned this pull request Feb 9, 2019
Merged
tanguyantoine added a commit that referenced this pull request Feb 9, 2019
@tanguyantoine
Revert "fix: controls not showing on Android lock screen (#227)" (#231)
86baaba 
This reverts commit 51a6fc2.
@13arturbruno
Copy link

I'm having the same issues with the version 0.9.9

@lufinkey
Copy link
Contributor Author

lufinkey commented Feb 13, 2019 •
edited
Loading

Yes please look at the issue as the change was reverted due to crash in some instances

@13arturbruno
Copy link

I'm kind of a layperson, should I use .9.8?

catmans1
catmans1 reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@catmans1 catmans1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If run on android device have version 23, It will happen crash.
I change a little code:

if ((!Build.MANUFACTURER.toLowerCase(Locale.getDefault()).contains("huawei") && Build.VERSION.SDK_INT < Build.VERSION_CODES.M)) {

it just different !

tanguyantoine pushed a commit that referenced this pull request Oct 12, 2020
@lufinkey @tanguyantoine
fix: controls not showing on Android lock screen (#227)
cbd6582
tanguyantoine pushed a commit that referenced this pull request Oct 12, 2020
@semantic-release-bot
chore(release): 0.9.8 [skip ci]
620c783 
## [0.9.8](v0.9.7...v0.9.8) (2019-02-01)

### Bug Fixes

* controls not showing on Android lock screen ([#227](#227)) ([51a6fc2](51a6fc2))
* remove extra pause event related to app suspension in IOS10+ ([6ee2a86](6ee2a86))
tanguyantoine added a commit that referenced this pull request Oct 12, 2020
@tanguyantoine
Revert "fix: controls not showing on Android lock screen (#227)" (#231)
8b4fe40 
This reverts commit 51a6fc2.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catmans1 catmans1 catmans1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lufinkey @tanguyantoine @13arturbruno @catmans1