Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

Controls hide on lock screen (Android) #192

Closed
2 tasks
ithustle opened this issue Nov 10, 2018 · 14 comments
Closed
2 tasks

Controls hide on lock screen (Android) #192

ithustle opened this issue Nov 10, 2018 · 14 comments

Comments

@ithustle
Copy link

ithustle commented Nov 10, 2018

Hi
Its not a issue but do you have an intention to update it to show music controls on lock screen if I set notification hide on screen?

I think will be a good asset on your good work.

Cheers

Célio Garcia

  1. Platform ?

    • iOS
    • [X ] Android
  2. Device

  • Simulator
  • [X ] Real device
@tanguyantoine
Copy link
Owner

If you have any skills and want to contribute, this is something we definitely can merge.

@ithustle
Copy link
Author

Great. I'd rather that was you because you are the owner and you know your project better than me but I'll try to do something, test it and make a PR ;)

@tanguyantoine
Copy link
Owner

You rock 👍

@PromitRai
Copy link

did anyone manage to solve this ?

@tanguyantoine
Copy link
Owner

@ithustle we are waiting your PR :-P

@ithustle
Copy link
Author

ithustle commented Jan 2, 2019

@tanguyantoine, I've started yesterday and dependecies are killing me ... gradle versions and whatever ..

@tanguyantoine
Copy link
Owner

haha good luck ^^

@ithustle
Copy link
Author

ithustle commented Jan 3, 2019

hehehe great incentive

@tanguyantoine
Copy link
Owner

sorry, I'm not an android expert ... at all

@Adam3306
Copy link

pls guys help

@lufinkey
Copy link
Contributor

lufinkey commented Feb 1, 2019

This should be fixed now with that PR

@ithustle
Copy link
Author

ithustle commented Feb 2, 2019

@lufinkey , I think you saved my ass 😆

@lufinkey
Copy link
Contributor

This issue should be re-opened since that PR crashed in some instances. I think I know a better way to implement it that doesn't hardcode the actions. I'll take another crack at it sometime this week

@tanguyantoine
Copy link
Owner

reproducible with 0.10.8?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants