More robust support for feature.id
#720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All data formats supported by Tangram have a
feature.id
property (at the topfeature
level, outsidefeature.properties
; some data sets may separately include an id or similar property withinfeature.properties
), but we haven't had full support for it. This PR fixes that:feature.id
persists wherever features are internally copied/synthesized/etc. internallyfeature.id
in user-authored JS scene functions with a new$id
variablefeature.id
in feature object results returned fromscene.queryFeatures()
feature.id
in the default uniqueness check forscene.queryFeatures()
, with$id
syntax used if specifying a list of properties to uniqueify on, e.g.:scene.queryFeatures({ unique: true })
,feature.id
will be included in uniqueness checkscene.queryFeatures({ unique: ['$id'] })
,feature.id
can be included in uniqueness check with$id
(un-prefixed names refer tofeature.properties
)