Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBP Milestone 1 review #283

Closed

Conversation

hbulgarini
Copy link

Sharing the same summary as tangle-network/dkg-substrate#471 since the same topics were identified in this repository:

In addition, please take some time to upgrade to the latest releases. Please take into account that next releases after v0.9.30, needed some storage migrations for Weights v2, meaning that launching the parachain with this current version might involve extra work while the chain is up and running.

Please refer to the following polkadot releases analysis reports for further information:

Polkadot Release Analysis v0.9.31 & v0.9.32: https://forum.polkadot.network/t/polkadot-release-analysis/1026
Polkadot Release Analysis v0.9.33: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-33/1287
Polkadot Release Analysis v0.9.34: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-34/1432
Polkadot Release Analysis v0.9.35: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-35/1509
Polkadot Release Analysis v0.9.36: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529

@hbulgarini hbulgarini changed the title Hb milestone review 1 SBP Milestone 1 review Jan 9, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 48.38% // Head: 50.63% // Increases project coverage by +2.25% 🎉

Coverage data is based on head (7ce6d62) compared to base (779162c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     paritytech/substrate#283      +/-   ##
==========================================
+ Coverage   48.38%   50.63%   +2.25%     
==========================================
  Files          56       54       -2     
  Lines        2135     2040      -95     
==========================================
  Hits         1033     1033              
+ Misses       1102     1007      -95     
Impacted Files Coverage Δ
pallets/asset-registry/src/lib.rs 81.86% <ø> (ø)
pallets/hasher/src/lib.rs 84.00% <ø> (ø)
pallets/key-storage/src/lib.rs 37.50% <ø> (ø)
pallets/linkable-tree/src/lib.rs 88.42% <ø> (ø)
pallets/mixer/src/lib.rs 70.09% <ø> (ø)
pallets/mt/src/lib.rs 90.00% <ø> (ø)
pallets/signature-bridge/src/lib.rs 80.51% <ø> (ø)
pallets/token-wrapper-handler/src/lib.rs 40.00% <ø> (ø)
pallets/token-wrapper/src/lib.rs 65.82% <ø> (ø)
pallets/vanchor-handler/src/lib.rs 55.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drewstone
Copy link
Contributor

@hbulgarini see the attached PR which addresses comments issued here. Let me know if that is good and we can close this!

@drewstone drewstone closed this Jan 17, 2023
@drewstone
Copy link
Contributor

@1xstj I've closed this since the completion email but do double check we've addressed all these items.

@hbulgarini
Copy link
Author

@1xstj I've closed this since the completion email but do double check we've addressed all these items.

very good! Thanks and good luck with the next milestone reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants