Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language overhaul 3 #5

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Language overhaul 3 #5

merged 8 commits into from
Jul 16, 2024

Conversation

3gf8jv4dv
Copy link

@3gf8jv4dv 3gf8jv4dv commented Jul 10, 2024 •
edited
Loading

Continue with the overhaul of en-US. Hopefully this will be my last overhaul, with only minor revisions to follow.

Take some opinions from Chiloven945 (Chiloven945@509469b). Thanks!

@3gf8jv4dv
Copy link
Author

@tangge233 @Chiloven945

Feedback is welcome!

@Chiloven945
Copy link

Thanks for taking my opinions! I will check it stat. and do more modification.

@3gf8jv4dv @Chiloven945
Overhaul 3
370cd0c 
Take some opinions from Chiloven945. Thanks!

Co-authored-by: ClovenBugle <116699482+Chiloven945@users.noreply.github.com>
@3gf8jv4dv
Copy link
Author

@Chiloven945

For some reason, I merged two commits into one. The new commit has exactly the same content as the previous two commits.

tangge233
tangge233 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Owner

@tangge233 tangge233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@Chiloven945
Copy link

I've done some new changes in my fork, sorry but I don't have enough time. I'll do more later.

@3gf8jv4dv 3gf8jv4dv mentioned this pull request Jul 10, 2024
Open
@3gf8jv4dv
Copy link
Author

I've done some new changes in my fork, sorry but I don't have enough time. I'll do more later.

I focused on other things for the time being. Waiting for you.

@3gf8jv4dv 3gf8jv4dv force-pushed the language-revise branch 2 times, most recently from cd4498d to debec67 Compare July 15, 2024 05:03
@3gf8jv4dv 3gf8jv4dv force-pushed the language-revise branch 3 times, most recently from 9bd59ac to 39b3a3f Compare July 15, 2024 17:30
@3gf8jv4dv @Chiloven945
Overhaul 3-1
78aa0b6 
Co-authored-by: ClovenBugle <116699482+Chiloven945@users.noreply.github.com>
@3gf8jv4dv 3gf8jv4dv marked this pull request as ready for review July 15, 2024 17:59
@3gf8jv4dv 3gf8jv4dv requested a review from tangge233 July 15, 2024 17:59
@3gf8jv4dv
Copy link
Author

3gf8jv4dv commented Jul 15, 2024 •
edited
Loading

Ready to merge.

I found some bugs on the code. I will submit review on the main PR after merge it.

@3gf8jv4dv 3gf8jv4dv force-pushed the language-revise branch 3 times, most recently from d48e182 to 359de7f Compare July 15, 2024 21:10
@3gf8jv4dv 3gf8jv4dv force-pushed the language-revise branch 2 times, most recently from b4ff5c3 to 632b176 Compare July 15, 2024 21:29
tangge233
tangge233 requested changes Jul 16, 2024
View reviewed changes
Copy link
Owner

@tangge233 tangge233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small problem.

@tangge233
Copy link
Owner

I'm sorry, that was my mistake.Nothing wrong actually.

@tangge233 tangge233 merged commit 1e5b538 into tangge233:Language Jul 16, 2024
10 checks passed
@3gf8jv4dv
Copy link
Author

Because the original code had a UI bug and I did not know a better way to fix it, I deleted it at the time.

If you have a better way, feel free to push new commits directly. Thanks!

@3gf8jv4dv 3gf8jv4dv deleted the language-revise branch July 16, 2024 01:33
tangge233 pushed a commit that referenced this pull request Dec 25, 2024
@wuliaodexiaoluo
Merge pull request #5 from Hex-Dragon/main
6e4f7fb 
sync
tangge233 pushed a commit that referenced this pull request Dec 25, 2024
@Pigeon0v0
Merge pull request #5 from Hill23333/myhint-new-style
26802fc 
feat: MyHint 的三态
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangge233 tangge233 tangge233 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3gf8jv4dv @Chiloven945 @tangge233