Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows separators #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: windows separators #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ export interface AssetsMap {
export const ASSETS_EXTENSION = 'svg';

export const loadPaths = async (dir: string): Promise<string[]> => {
const globPath = join(dir, `**/*.${ASSETS_EXTENSION}`);
// glob has issues with windows separators, so we need to replace them
const globPath = join(dir, `**/*.${ASSETS_EXTENSION}`).replace(/\\/g,'/');

const files = await glob(globPath, {});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an alternative to the replacement:

Suggested change
const files = await glob(globPath, {});
const files = await glob(globPath, { windowsPathsNoEscape: true });

Not sure which is better, though.

If doing it that way, the join should probably not use a specific separator for consistency:

join(dir, '**', `*.${ASSETS_EXTENSION}`)


if (!files.length) {
Expand Down