Merge branch 'sqlcommenting-mysql-driver' into mysqlclient-sqlcomment

tammy-baylis-swi · Oct 16, 2024 · 637b95b · 637b95b
2 parents c9c0dc5 + 4e6ab3f
commit 637b95b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...n/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py b/...n/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
@@ -289,12 +289,20 @@ def calculate_commenter_data(
         if not self.enable_commenter:
             return commenter_data
 
-        db_driver = self.connect_module.__name__
+        try:
+            db_driver = self.connect_module.__name__
+        except AttributeError:
+            db_driver = "unknown"
+
         db_version = ""
         if db_driver in _DB_DRIVER_ALIASES:
             db_version = util_version(_DB_DRIVER_ALIASES[db_driver])
         else:
-            db_version = self.connect_module.__version__
+            try:
+                db_version = self.connect_module.__version__
+            except AttributeError:
+                db_driver = "unknown"
+
         commenter_data = {
             "db_driver": f"{db_driver}:{db_version.split(' ')[0]}",
             "dbapi_threadsafety": self.connect_module.threadsafety,