Created a centralized please command #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to test this in VSCode and jet brains on the mac but I was unable to test the other implementations to make sure they're working. I could use a hand with testing on other platforms to make sure these things still work, though the implementations appear correct to me right now. |
nriley
reviewed
Aug 11, 2024
There was a problem hiding this comment.
Makes sense to use a tag for this to avoid "promising what we can't deliver". With the exception of the tiny nit I mentioned, the only other thing I can think that might is whether we'd like to continue sending an empty string for "please" by itself or define two voice commands and an action with an optional argument. I don't feel strongly one way or the other.
AndreasArvidsson
requested changes
Aug 24, 2024
To avoid divergence in the grammar for please commands, it is useful to define a centralized tag and allow it to be overridden in command implementations.
- It looks like the formatting was more than just adding a comma ; this should be cleaner now
jaresty
force-pushed
the
centralized-please-command
branch
from
3750d85
to
1a17a4c
Compare
- Only insert text if it was searched for
AndreasArvidsson
approved these changes
Oct 4, 2024
nriley
requested changes
Oct 5, 2024
auscompgeek
reviewed
Oct 6, 2024
nriley
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid divergence in the grammar for please commands, it is useful to define a centralized tag and allow it to be overridden in command implementations.
Addresses #1536