Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail to documentation #1380

Merged
merged 11 commits into from
Feb 18, 2024
Merged

Conversation

chrisnicollo
Copy link
Contributor

Currently, the readme file describes several core features of these scripts, but a lot of the functionality is left out. This could make it difficult to get a good sense of what these scripts are capable of on first glance. Also, the current directory structure does not always make it clear where to look to discover and update certain types of commands.

Here I am providing an overview of the subdirectories within core and plugin for someone to skim through and determine which folders are most likely to have the commands they're looking for. I also added a bit more detail about mouse commands and tags.

@nriley
Copy link
Collaborator

nriley commented Feb 3, 2024

Thanks, this seems helpful.

What do you think about putting the documentation for the individual subdirectories into those subdirectories and linking to it? The top level README is already getting quite large.

@chrisnicollo
Copy link
Contributor Author

I agree with your suggestion and moved most of my content to subfolders. One thing I'd like to address though is that I don't understand the point of using the command within screens to show the index of your different computer screens. If I understood the purpose of that, I could give that context within the documentation too.

@nriley
Copy link
Collaborator

nriley commented Feb 4, 2024

It lets you see how Talon is numbering your screens (which should match your OS, but may be easier to access). It helps if you use voice commands to move windows between screens — e.g. "snap screen 3". Thanks!

Copy link
Member

@knausj85 knausj85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks.

@knausj85 knausj85 merged commit 1818074 into talonhub:main Feb 18, 2024
2 checks passed
Mark-Phillipson pushed a commit to Mark-Phillipson/community that referenced this pull request Mar 29, 2024
sisi-sh added a commit to sisi-sh/sisi_talon that referenced this pull request Apr 1, 2024
* 'main' of github.com:talonhub/community: (73 commits)
  add lowercased firefox-esr to firefox.py (talonhub#1410)
  configurable number prefix without mouse grid (talonhub#1342)
  Update app.exe matching to work with both public and beta Talon (talonhub#1385)
  Add comment line to javascript (talonhub#1387)
  Add detail to documentation (talonhub#1380)
  Switch to black pre-commit mirror (talonhub#1378)
  Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379)
  [pre-commit.ci] pre-commit autoupdate (talonhub#1376)
  coalesce some list updates (talonhub#1348)
  Remove unused setting from c code language (talonhub#1368)
  mouse: adding synonyms for starting left drag. (talonhub#1356)
  Adds commands to focus on the last application (talonhub#1336)
  Stop using “brackets” to mean “braces” (talonhub#1344)
  Update settings descriptions (talonhub#1371)
  Revert changes to `user.mouse_enable_pop_click` (talonhub#1370)
  Fix typo in `mouse.py` variable name (talonhub#1372)
  Convert boolean settings to boolean (talonhub#1360)
  Add ruby op-or-equals command (talonhub#1347)
  added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367)
  added app name Caja (fork of Nautilus) (talonhub#1366)
  ...
emragins pushed a commit to emragins/talon-community that referenced this pull request May 28, 2024
MartinRykfors pushed a commit to MartinRykfors/knausj_talon that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants