Skip to content

Commit

Permalink
Respond to PR feedback
Browse files Browse the repository at this point in the history
- Implemented focus_last as a python action instead of using talon script
- I was unable to test the Linux implementation and I would appreciate some help on that
  • Loading branch information
jaresty committed Dec 28, 2023
1 parent 46a5e6d commit dfba0c6
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions core/windows_and_tabs/window_management.talon
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ window hide: app.window_hide()
focus <user.running_applications>: user.switcher_focus(running_applications)
# following only works on windows. Can't figure out how to make it work for mac. No idea what the equivalent for linux would be.
focus$: user.switcher_menu()
focus last: user.focus_last()
running list: user.switcher_toggle_running()
running close: user.switcher_hide_running()
launch <user.launch_applications>: user.switcher_launch(launch_applications)
Expand Down
3 changes: 0 additions & 3 deletions core/windows_and_tabs/window_management_mac.talon

This file was deleted.

3 changes: 0 additions & 3 deletions core/windows_and_tabs/window_management_windows.talon

This file was deleted.

3 changes: 3 additions & 0 deletions core/windows_and_tabs/windows_and_tabs_linux.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ def window_hide_others():

def window_open():
actions.key("ctrl-n")

def focus_last():
actions.key("alt-tab")
3 changes: 3 additions & 0 deletions core/windows_and_tabs/windows_and_tabs_mac.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ def window_previous():

def window_next():
actions.key("cmd-`")

def focus_last():
actions.key("cmd-tab")
3 changes: 3 additions & 0 deletions core/windows_and_tabs/windows_and_tabs_win.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ def window_hide_others():

def window_open():
actions.key("ctrl-n")

def focus_last():
actions.key("alt-tab")

0 comments on commit dfba0c6

Please sign in to comment.