Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of default copy constructor causes SEGVs #1

Open
jamesmulcahy opened this issue Sep 18, 2014 · 0 comments · May be fixed by #2
Open

Use of default copy constructor causes SEGVs #1

jamesmulcahy opened this issue Sep 18, 2014 · 0 comments · May be fixed by #2

Comments

@jamesmulcahy
Copy link

Using the default copy constructor leads to the Data pointer being shared between copies of the client. Once a client gets deleted, it deletes the Data which is shared across all clients. Eventually, this leads to a SEGV or malloc error.
jamesmulcahy added a commit to jamesmulcahy/statsd-client-cpp that referenced this issue Sep 18, 2014
@jamesmulcahy
Implement copy constructor to prevent malloc errors
0d0ac4a 
Fixes talebook#1
@jamesmulcahy jamesmulcahy linked a pull request Sep 18, 2014 that will close this issue
Open
jamesmulcahy added a commit to jamesmulcahy/statsd-client-cpp that referenced this issue Dec 2, 2014
@jamesmulcahy
Also clear init() flag in copy constructor
1db5616 
- This ensures a new socket is created in the new client

Properly fixes talebook#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement copy constructor to prevent malloc errors jamesmulcahy/statsd-client-cpp
1 participant
@jamesmulcahy