chore: update dom helpers to v5 #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch on react-bootstrap/dom-helpers#64. I had tried to do this earlier but didn't have time to figure out why the upgrade made all my tests fail. |
|
dom-helpers 5.1.3 is out now |
|
hmm, the tests seem to fail |
|
Yep the tests were working locally but for some reason failing on CI. I'm hoping to give it another look when I get the chance. The culprit seems to be |
|
I changed enough stuff that this was a little messy to rebase, so I replaced it with #374. It was a bug in dom-helpers that was making tests fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR updates dom-helpers to the latest version.
scrollTopindom-helpersv5 breaks the tests, so I wrote a temporary implementation and submitted a PR to fix it here : react-bootstrap/dom-helpers#64Once(/if) the dom-helpers PR is merged I'll mark this one as ready for review.
dom-helpers5is temporary and helps to incrementally do the migrationAffects : doczjs/docz#979