Make sure scrollRestoration is writable. Fixes #126

taion · Jan 16, 2018 · 0d212a9 · 0d212a9
1 parent 493c9b0
commit 0d212a9
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -26,7 +26,11 @@ export default class ScrollBehavior {
     /* istanbul ignore else: Travis browsers all support this */
     if ('scrollRestoration' in window.history) {
       this._oldScrollRestoration = window.history.scrollRestoration;
-      window.history.scrollRestoration = 'manual';
+      try {
+        window.history.scrollRestoration = 'manual';
+      } catch () {
+        this._oldScrollRestoration = null;
+      }
     } else {
       this._oldScrollRestoration = null;
     }

diff --git a/test/ScrollBehavior.test.js b/test/ScrollBehavior.test.js
@@ -65,6 +65,29 @@ describe('ScrollBehavior', () => {
             },
           ]);
         });
+
+        it('should not crash when history is not available', (done) => {
+          Object.defineProperty(window.history, 'scrollRestoration', {
+            value: 'auto',
+            // See https://github.com/taion/scroll-behavior/issues/126
+            writable: false,
+            enumerable: true,
+            configurable: true,
+          });
+
+          const history = withRoutes(withScroll(createHistory()));
+
+          unlisten = run(history, [
+            () => {
+              expect(scrollTop(window)).to.equal(0);
+
+              delete window.history.scrollRestoration;
+              window.history.scrollRestoration = 'auto';
+
+              done();
+            },
+          ]);
+        });
       });
 
       describe('custom behavior', () => {