Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all plugins are executed for a given candidate #6540

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

RobinMalfait
Copy link
Member

We had an early return so that once a plugin was matched, that we could
stop running the code through the other plugins. However, in this case
we have an issue that user defined css is technically also a plugin.

This means that:

  • bg-green-light
    Would check for:
  • bg-green-light (no hit, continue)
  • bg-green (Hit! Don't execute next plugins)
  • bg (This is the one that would have generated bg-green-light)

We tested this change and it doesn't seem to have an impact functionally
and also not really performance wise.

Fixes: #6478

We had an early return so that once a plugin was matched, that we could
stop running the code through the other plugins. However, in this case
we have an issue that user defined css is technically also a plugin.

This means that:
  - `bg-green-light`
Would check for:
  - `bg-green-light` (no hit, continue)
  - `bg-green` (Hit! Don't execute next plugins)
  - `bg` (This is the one that would have generated `bg-green-light`)

We tested this change and it doesn't seem to have an impact functionally
and also not really performance wise.
@RobinMalfait RobinMalfait merged commit deb68d5 into master Dec 15, 2021
@RobinMalfait RobinMalfait deleted the fix-6478 branch December 15, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background color fails to compile when some other selector has the same color prefix
1 participant