Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add col- and row- span-full utility #2471

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Sep 30, 2020

add col-span-full and row-span-full per @flybayer in #2467 (comment)

i'm new to this codebase so pardon if i missed something but... it looks like this is the only thing i have to do!

add `col-span-full` and `row-span-full` per @flybayer in tailwindlabs#2467 (comment)
@adamwathan
Copy link
Member

Hey @sw-yx thanks! Make sure to run yarn rebuild-fixtures to update the test fixtures and then double check the diff to make sure none of the changes are unexpected, but otherwise looks good 👍

@simonswiss
Copy link
Contributor

Good stuff @sw-yx, thank you.

And thanks to @flybayer for the suggestion! 👍

@swyxio
Copy link
Contributor Author

swyxio commented Oct 1, 2020

lol i like how the sun never sets on tailwind labs

@adamwathan adamwathan merged commit ce78b69 into tailwindlabs:master Oct 4, 2020
@adamwathan
Copy link
Member

Thanks @sw-yx!

@swyxio swyxio deleted the patch-1 branch October 4, 2020 18:13
adamwathan pushed a commit that referenced this pull request Oct 6, 2020
* add col- and row- span-full utility

add `col-span-full` and `row-span-full` per @flybayer in #2467 (comment)

* fixtures

Co-authored-by: swyx <wanshawn@amazon.com>
adamwathan pushed a commit that referenced this pull request Oct 7, 2020
* add col- and row- span-full utility

add `col-span-full` and `row-span-full` per @flybayer in #2467 (comment)

* fixtures

Co-authored-by: swyx <wanshawn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants