Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntelliSense class suggestions #15857

Merged
merged 13 commits into from
Jan 28, 2025
Merged

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Jan 25, 2025

This PR fixes a few problems with IntelliSense:

  • Default installs suggest font weight utilities twice
  • When setting --font-weight-*: initial; the default weights are still suggested
  • Setting --spacing-*: initial; still shows suggestions for utilities using the spacing scale assuming it's multiplier-based. Removing the --spacing: … key should make them entirely theme driven instead.
  • The default container query variants like @sm, @md, etc… aren't suggested. Only the @min-sm and @max-sm style ones are.

Fixes tailwindlabs/tailwindcss-intellisense#1133
Fixes tailwindlabs/tailwindcss-intellisense#1136
Fixes #15811

@thecrypticace thecrypticace marked this pull request as ready for review January 28, 2025 13:24
@thecrypticace thecrypticace requested a review from a team as a code owner January 28, 2025 13:24
@florianbouvot
Copy link
Contributor

florianbouvot commented Jan 28, 2025

@thecrypticace can you reorder colors suggestions 50 before 100, 200, ... instead of between 400 and 500?

Capture d’écran 2025-01-28 à 15 19 01

@florianbouvot
Copy link
Contributor

florianbouvot commented Jan 28, 2025

@thecrypticace I think there are the same issue with spacing 2 after 16 ...

Capture d’écran 2025-01-28 à 15 22 34

This will ensure that strings that contain numbers are sorted as if a
human would sort it.
@thecrypticace thecrypticace merged commit 1eb2980 into next Jan 28, 2025
5 checks passed
@thecrypticace thecrypticace deleted the fix/v4-incorrect-suggestions branch January 28, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants