Set outline icons' stroke-width on <svg> for Tailwind compatibility #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Heroicons' outline icons compatible with Tailwind's stroke-width
stroke-1
, etc. classes, as well as any CSS styles applying thestroke-width
property.It fixes the problem discussed in #241, #236, and #263, by moving the
stroke-width
attribute from the<path>
nodes to the<svg>
element. This allows CSS inheritance to work properly when styles with higher specificity (like the Tailwind classes) are applied to the<svg>
. (Link to the stroke-width spec for reference.)Included are changes to all outline icons, plus the compiled optimized svgs. I've confirmed it works properly out-of-the-box and with the Tailwind classes.
I've built the react and vue versions from this too, and they look right to me, but since I don't use those it would be good to have someone double-check them closely before merging this.