-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix closing components using the transition
prop, and after scrolling the page
#3407
Commits on Aug 1, 2024
-
useDidElementMove
: handleHTMLElement
This change should be temporary, and it will allow us to use the `useDidElementMove` with ref objects and direct `HTMLElement`s.
Configuration menu - View commit details
-
Copy full SHA for 7fd628f - Browse repository at this point
Copy the full SHA 7fd628fView commit details -
useResolveButtonType
: handleHTMLElement
This change should be temporary, and it will allow us to use the `useResolveButtonType` hook with ref objects and direct `HTMLElement`s.
Configuration menu - View commit details
-
Copy full SHA for ffdc6c4 - Browse repository at this point
Copy the full SHA ffdc6c4View commit details -
useRefocusableInput
: handleHTMLElement
This change should be temporary, and it will allow us to use the `useRefocusableInput` hook with ref objects and direct `HTMLElement`s.
Configuration menu - View commit details
-
Copy full SHA for 7dedb66 - Browse repository at this point
Copy the full SHA 7dedb66View commit details -
useTransition
: handleHTMLElement
Accept `HTMLElement| null` instead of `MutableRefObject<HTMLElement | null>` in the `useTransition` hook.
Configuration menu - View commit details
-
Copy full SHA for b194e65 - Browse repository at this point
Copy the full SHA b194e65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f90b1e - Browse repository at this point
Copy the full SHA 6f90b1eView commit details -
Menu
: trackbutton
anditems
elements in stateSo far we've been tracking the `button` and the the `items` DOM nodes in a ref. Typically, this is the way you do it, you keep track of it in a ref, later you can access it in a `useEffect` or similar by accessing the `ref.current`. There are some problems with this. There are places where we require the DOM element during render (for example when picking out the `.id` from the DOM node directly). Another issue is that we want to re-run some `useEffect`'s whenever the underlying DOM node changes. We currently work around that, but storing it directly in state would solve these issues because the component will re-render and we will have access to the new DOM node.
Configuration menu - View commit details
-
Copy full SHA for a7bbcee - Browse repository at this point
Copy the full SHA a7bbceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6298af9 - Browse repository at this point
Copy the full SHA 6298af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef6afd5 - Browse repository at this point
Copy the full SHA ef6afd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd4d58 - Browse repository at this point
Copy the full SHA 5bd4d58View commit details -
Configuration menu - View commit details
-
Copy full SHA for d01b25b - Browse repository at this point
Copy the full SHA d01b25bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d14b2c - Browse repository at this point
Copy the full SHA 2d14b2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 632b2d0 - Browse repository at this point
Copy the full SHA 632b2d0View commit details -
simplify
useDidElementMove
, only acceptHTMLElement | null
This doesn't support the `MutableRefObject<HTMLElement | null>` anymore.
Configuration menu - View commit details
-
Copy full SHA for 477f259 - Browse repository at this point
Copy the full SHA 477f259View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a90d34 - Browse repository at this point
Copy the full SHA 6a90d34View commit details -
simplify
useResolveButtonType
, only handleHTMLElement | null
We don't handle `MutableRefObject<HTMLElement | null>` anymore
Configuration menu - View commit details
-
Copy full SHA for d56dfcf - Browse repository at this point
Copy the full SHA d56dfcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7128c24 - Browse repository at this point
Copy the full SHA 7128c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d71797 - Browse repository at this point
Copy the full SHA 4d71797View commit details -
Only accept `HTMLElement | null` instead of `MutableRefObject<HTMLElement | null>`
Configuration menu - View commit details
-
Copy full SHA for 8d26d4c - Browse repository at this point
Copy the full SHA 8d26d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e61373 - Browse repository at this point
Copy the full SHA 7e61373View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 697468d - Browse repository at this point
Copy the full SHA 697468dView commit details