Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing components using the transition prop, and after scrolling the page #3407

Merged
merged 20 commits into from
Aug 2, 2024

Commits on Aug 1, 2024

  1. useDidElementMove: handle HTMLElement

    This change should be temporary, and it will allow us to use the
    `useDidElementMove` with ref objects and direct `HTMLElement`s.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7fd628f View commit details
    Browse the repository at this point in the history
  2. useResolveButtonType: handle HTMLElement

    This change should be temporary, and it will allow us to use the
    `useResolveButtonType` hook with ref objects and direct `HTMLElement`s.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ffdc6c4 View commit details
    Browse the repository at this point in the history
  3. useRefocusableInput: handle HTMLElement

    This change should be temporary, and it will allow us to use the
    `useRefocusableInput` hook with ref objects and direct `HTMLElement`s.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7dedb66 View commit details
    Browse the repository at this point in the history
  4. useTransition: handle HTMLElement

    Accept `HTMLElement| null` instead of `MutableRefObject<HTMLElement |
    null>` in the `useTransition` hook.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b194e65 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6f90b1e View commit details
    Browse the repository at this point in the history
  6. Menu: track button and items elements in state

    So far we've been tracking the `button` and the the `items` DOM nodes in
    a ref. Typically, this is the way you do it, you keep track of it in a
    ref, later you can access it in a `useEffect` or similar by accessing
    the `ref.current`.
    
    There are some problems with this. There are places where we require the
    DOM element during render (for example when picking out the `.id` from
    the DOM node directly).
    
    Another issue is that we want to re-run some `useEffect`'s whenever the
    underlying DOM node changes. We currently work around that, but storing
    it directly in state would solve these issues because the component will
    re-render and we will have access to the new DOM node.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a7bbcee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6298af9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ef6afd5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5bd4d58 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d01b25b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2d14b2c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    632b2d0 View commit details
    Browse the repository at this point in the history
  13. simplify useDidElementMove, only accept HTMLElement | null

    This doesn't support the `MutableRefObject<HTMLElement | null>` anymore.
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    477f259 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6a90d34 View commit details
    Browse the repository at this point in the history
  15. simplify useResolveButtonType, only handle HTMLElement | null

    We don't handle `MutableRefObject<HTMLElement | null>` anymore
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d56dfcf View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7128c24 View commit details
    Browse the repository at this point in the history
  17. simplify useElementSize

    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4d71797 View commit details
    Browse the repository at this point in the history
  18. simplify useOutsideClick

    Only accept `HTMLElement | null` instead of `MutableRefObject<HTMLElement | null>`
    RobinMalfait committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8d26d4c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    7e61373 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. update changelog

    RobinMalfait committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    697468d View commit details
    Browse the repository at this point in the history