Ensure TransitionRoot component without props transitions correctly
#3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a weird one, but you can use the `TransitionRoot` component without any props for transitions themselves (so no real transition can happen). Even crazier, it can happen that it doesn't even render a DOM node, but just its children. At this point, the `TransitionRoot` component is purely there for orchestration purposes of child components. Since there is no DOM node in certain situations, the transitions (and its `onStart` and `onStop` callbacks) won't even happen at all. This causes a bug (obvious in react strict mode) where children don't properly mount or the transition component doesn't properly unmount.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
approved these changes
Apr 26, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change that the
Transitioncomponent renders aFragmentby default. We also made sure that aTransitionRootcomponent (which could exist for orchestration purposes for child transitions) doesn't render a DOM node when it doesn't need to. This is the case if it doesn't have anyenter,enterFrom,enterTo,leave,leaveFrom, orleaveToprops.However, this caused a bug where the
Transitioncomponent doesn't properly mount or unmount its children when theTransitionRootcomponent doesn't render a DOM node. This is because theTransitioncomponent relies on DOM transition events and will call theonStartandonStopcallbacks when the transition starts and ends.To solve this, we make sure to still call the
onStartandonStopcallbacks, because you can think of it as the transition was done immediately.